kitovu-bot / kitovu

OpenHSR Connect 2
GNU General Public License v3.0
5 stars 2 forks source link

conflict handling when filestate = BOTH_CHANGED #52

Open bytinbit opened 6 years ago

bytinbit commented 6 years ago

When BOTH files individually changed, we currently override the local file, but this can and should later be handled as a user decision.

Implementation in settings with override / ignore / ask every time / rename

bytinbit commented 6 years ago

we agree: the simplest implementation is to just rename the local file and download the remote changed file anyway.

another issue has been opened to cover a "second stage": the user can determine in the config what should be done when both (remote, local) have changed.

The-Compiler commented 5 years ago

@bytinbit started some work on this in the filecache-both-changed branch. Some tests are still missing (we wanted some more fine-grained tests for the logic in syncing.py with the different file states), but otherwise it should be done.