kitovu-bot / kitovu

OpenHSR Connect 2
GNU General Public License v3.0
5 stars 2 forks source link

Added prototype for the configuration file #6

Closed ThunderKey closed 6 years ago

codecov[bot] commented 6 years ago

Codecov Report

Merging #6 into master will increase coverage by 3.85%. The diff coverage is 89.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   88.08%   91.93%   +3.85%     
==========================================
  Files          15       16       +1     
  Lines         361      459      +98     
  Branches       15       27      +12     
==========================================
+ Hits          318      422     +104     
+ Misses         40       32       -8     
- Partials        3        5       +2
Impacted Files Coverage Δ
src/kitovu/cli.py 0% <0%> (ø) :arrow_up:
tests/sync/test_syncing.py 100% <100%> (ø) :arrow_up:
tests/test_dummyplugin.py 100% <100%> (ø) :arrow_up:
tests/sync/test_settings.py 100% <100%> (ø)
src/kitovu/sync/syncing.py 100% <100%> (+46.87%) :arrow_up:
tests/helpers/dummyplugin.py 100% <100%> (+3.03%) :arrow_up:
src/kitovu/utils.py 67.85% <59.09%> (-32.15%) :arrow_down:
src/kitovu/sync/plugin/smb.py 90.9% <66.66%> (ø) :arrow_up:
src/kitovu/sync/settings.py 92% <92%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8681019...ff1802d. Read the comment docs.

ThunderKey commented 6 years ago

I've removed the YAMLSettingsFactory and moved the methods to the Settings class itself

The-Compiler commented 6 years ago

I don't know why (maybe because of the PyPI change?), but the hashes changed, which caused builds to fail. Pushed an updated Pipfile.lock now, which seems to have helped.

Merging this now!