kitovu-bot / kitovu

OpenHSR Connect 2
GNU General Public License v3.0
5 stars 2 forks source link

Initial prototype of a moodle plugin #7

Closed The-Compiler closed 6 years ago

codecov[bot] commented 6 years ago

Codecov Report

Merging #7 into master will decrease coverage by 5.05%. The diff coverage is 40.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   96.33%   91.27%   -5.06%     
==========================================
  Files          30       31       +1     
  Lines        1090     1192     +102     
  Branches       59       74      +15     
==========================================
+ Hits         1050     1088      +38     
- Misses         30       93      +63     
- Partials       10       11       +1
Impacted Files Coverage Δ
src/kitovu/sync/syncplugin.py 100% <100%> (ø) :arrow_up:
tests/helpers/dummyplugin.py 100% <100%> (ø) :arrow_up:
src/kitovu/sync/plugin/moodle.py 34.78% <34.78%> (ø)
src/kitovu/sync/syncing.py 92.53% <66.66%> (-2.71%) :arrow_down:
src/kitovu/sync/plugin/smb.py 89.33% <66.66%> (-2.1%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1adf569...fb83202. Read the comment docs.

The-Compiler commented 6 years ago

I refactored how the mtime is set for files (in b12fbf0de65596146e436a13f551a0feb759c921), as the previous approach had various shortcomings:

What I did instead is that each plugin returns an mtime in recieve_file (optional, None is also possible), and syncing.py takes care of applying it.

What do you think of that?

The-Compiler commented 6 years ago

Merging this now even if it doesn't have tests yet, as I think this has some things important for today's review (like updating the local mtime correctly so digests actually match up).

I opened issues for the remaining things: