search

kitovu-bot / kitovu

OpenHSR Connect 2
GNU General Public License v3.0
5 stars 2 forks source link

Gui import check #71

Closed lroellin closed 5 years ago

lroellin commented 5 years ago

This fixes #70.

I'm not sure if the style of the user message is good, and if the code should be somewhere else, but I'm quite content the way it is.

I haven't written any tests of it, since I don't know how you would go about faking having/not having this module installed.

One small problem: at least in my shell (zsh) I had to escape the [ and ] to get it to install properly, don't know if we should warn users of this. On the other hand, it should be clear that the message comes from zsh and not the package.

I've just tested with pip install .[gui] (no space behind that dot), and that worked.

lroellin commented 5 years ago

Should be fixed! Feedback very appreciated :)

The-Compiler commented 5 years ago

LGTM now, but I wonder where the @codecov bot went... Anyways, imports are very hard to test properly (as patching python's import system also means pytest can't import things it needs :laughing:), so I'm fine with merging this without tests.

Thanks! :+1: