search

kitovu-bot / kitovu

OpenHSR Connect 2
GNU General Public License v3.0
5 stars 2 forks source link

Dummyplugin #8

Closed bytinbit closed 6 years ago

bytinbit commented 6 years ago

Please review my marvelous dummy plugin with its tests.

codecov[bot] commented 6 years ago

Codecov Report

Merging #8 into master will increase coverage by 3.36%. The diff coverage is 98.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   84.87%   88.23%   +3.36%     
==========================================
  Files          13       15       +2     
  Lines         271      357      +86     
  Branches       11       12       +1     
==========================================
+ Hits          230      315      +85     
- Misses         39       40       +1     
  Partials        2        2
Impacted Files Coverage Δ
tests/test_dummyplugin.py 100% <100%> (ø)
tests/helpers/dummyplugin.py 96.96% <96.96%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c5ac5a6...24aa39f. Read the comment docs.

The-Compiler commented 6 years ago

Merged with some small changes - see the commits listed above. I added some details/rationales in the commit messages.

Thanks, and sorry for the delay!