search

kits-ab / LogLady

Log file viewer
https://loglady.dev/
MIT License
8 stars 0 forks source link

Update of loglady.dev old images and text #509

Closed Abdelkad3r closed 4 years ago

Abdelkad3r commented 4 years ago

Through this update i renewed the images (with loglady demo) and added some descriptions into loglady.dev website.

loglady dev
Atmanea commented 4 years ago

I have two things I would want to improve a bit here, one big and one small thing. Both are just my opinions though so please feel free to disagree. The big thing is the gif you replaced is kind of slow in its pacing. It would be better to try to match the pace that the video before this one had. The small thing (which might just be me nitpicking here so nothing serious) is that I would've changed the grammar a bit of the text you added. Currently it says "... with palette of the best colors we choose for you" and I would've modified it to "with a palette of the best colors we've chosen for you" if we want it more grammatically correct (but my english isn't perfect either so I might be wrong). Alternatively it could just say "with colors of your choosing" if we want to keep it simple.

Techlemariam commented 4 years ago

I agree with @Atmanea 's comment. Also maybe I'm mistaking but are these updates too new in comparision with the latest released version? In that case I'm wondering if we could:

  1. Wait until a new version has been released before we implement this pull request. The latest released version (1.3.0) does not for example include the new cool colorpicker so maybe it's confusing for everyone downloading loglady for that reason :) or
  2. Use this pull request to update the images and text to sync better with version 1.3.0
Abdelkad3r commented 4 years ago

@Atmanea i updated the demo to faster one, then i updated the text, it becomes grammatically better than the old one.