search

kitsilanosoftware / Bosphorus

Alternative implementation of a subset of Unity3D (GPL/Commercial) to allow Unity3D-based code to migrate elsewhere
1 stars 0 forks source link

YamlDotNet pull request TODO #28

Open bobsummerwill opened 9 years ago

bobsummerwill commented 9 years ago

Hi Bob,

Is there still work TODO on YamlDotNet which I'll need to pick up to keep working on Disunity? Did you submit pull requests?

What's the status? Thanks!

Yes and no.

My (mandatory) pull request still hasn't been merged. A (slightly different) patch should be cooked up which allows to toggle the parser between the YAML 1.1 and 1.2 semantics:

https://github.com/aaubry/YamlDotNet/pull/102#issuecomment-49840286

It's in my queue, but under a lot of other stuff :) In the meantime, please continue using the Kitsilano fork.

Additionally, some of the custom parsing done in Disunity could be generalized and folded back into the YamlDotNet classes, and the resulting patches turned into pull requests. This is lower priority, as it is only a "cleanup." The upside of doing so would be: less custom parsing in Disunity.

HTH, -D

ztzg commented 9 years ago

I would not start the second part ("cleaning up") before all the types from all asset file types are successfully parsed; a "pretty" API which does not cover 100% of the requirements does not seem to be a worthwhile endeavor.

It is also likely to complicate YDN a bit; such a pull request may be refused.

bobsummerwill commented 9 years ago

Right ... that makes sense. Thanks!