Lightning, Grace message, EXP/Level reset

kitskub / MyHungerGames

http://dev.bukkit.org/server-mods/myhungergames/

13 stars 23 forks source link

Lightning, Grace message, EXP/Level reset #41

Closed ov3rk1ll closed 11 years ago

ov3rk1ll commented 11 years ago

Fix for http://dev.bukkit.org/server-mods/myhungergames/tickets/44-show-message-at-the-beginning-and-end-of-grace-period/
Fix for http://dev.bukkit.org/server-mods/myhungergames/tickets/45-lightning-on-death-and-when-only-x-players-are-left/
InventorySave will now save/reset level and exp

kitskub commented 11 years ago

Can you update the config.yml for the new nodes? Also, instead of making the lightning and graceperiod stuff in the same as the randomLocs, add it to a different runnable.

kitskub commented 11 years ago

I'm not sure I like having two different stats system. If you want to the new GameStats, could you remove the old one?

ov3rk1ll commented 11 years ago

I can remove the old one. I can have the same data (updateGames, updatePlayers) sent from the new one or we make one entirely different that works for "everyone"

kitskub commented 11 years ago

I'm not against combining them like you did. If the new one works (and has all the features of the old one) you can just delete the old one, and i'll update the web side

ov3rk1ll commented 11 years ago

It is missing the SQLStat getStat / requestPlayer code but I can just copy that over and keep it static. will do that a bit later then.

ov3rk1ll commented 11 years ago

StatHandler is not fully replaced. However I did mess up my last commit a bit and now your last changes are in there as well....

kitskub commented 11 years ago

not? or now?

ov3rk1ll commented 11 years ago

... why the hell does my keyboard thinks i want to type not when i hit w?.... It should say "StatHandler is NOW fully replaced."

kitskub commented 11 years ago

I manually merged most of these changes. Except for the outside-game pvp setting.

ov3rk1ll commented 11 years ago

The pvp outside game function is something I need for my server. Since you can just disable it...why not...

If you have them all merged manually please close this pull request so i can fetch back from upstream.

kitskub commented 11 years ago

There are plenty of pvp disabling plugins out there. However, I don't want to clutter up the config.yml any more than it is. On that note. I'm going to close this, any more changes can be made in another PR

kitskub commented 11 years ago

http://dev.bukkit.org/server-mods/pvptoggle/