search

kitskub / MyHungerGames

http://dev.bukkit.org/server-mods/myhungergames/
13 stars 23 forks source link

New random chest algorithm #43

Closed greatman closed 11 years ago

greatman commented 11 years ago

Rewrote the chest algorithm. Looks working in my local tests.

Signed-off-by: William Lebel lebelwilliam@gmail.com

kitskub commented 11 years ago

Thank you!

greatman commented 11 years ago

No problem ;)

kitskub commented 11 years ago

What made you want to create a PR? I mean, how long have you been following development?

greatman commented 11 years ago

Gonna use it on my server :P

kitskub commented 11 years ago

Oh nice!

kitskub commented 11 years ago

I realized two problems with this: 1) It provides no variance of the number of items chest-to-chest 2) It doesn't account for the possible case where no items make it (Creating an IndexOOBException

I'm currently writing new code to fix this

kitskub commented 11 years ago

Also, the slots list is misused.