search

kitsonk / kview

A web app for Deno KV
https://kview.deno.dev
MIT License
69 stars 5 forks source link

feat(nav): add breadcrumbs #2

Closed hashrock closed 11 months ago

hashrock commented 11 months ago

This PR introduces a simple breadcrumb navigation. For now, it's only for Local. wdyt?

image

image

kitsonk commented 11 months ago

This is a great idea. I had been thinking about it too. What I was thinking though is that it would be good to move it to the header, to the right of the logo.

example_—_kview

Let me know if are interested in doing that. If not, I can use your PR as the base for that.

hashrock commented 11 months ago

Yeah! I'm interesting in implementing header breadcrumbs. I'll update this PR later

hashrock commented 11 months ago

@kitsonk Sorry for the delay! I've moved the UI to the header. I think you're working on other UI development, so for now, I'm keeping it local only to avoid conflicts

kitsonk commented 11 months ago

@hashrock I have added a couple features. I tried to rebase your PR with main, but I don't have permission to push an update.

hashrock commented 11 months ago

Hmm, I have "Allow edits and access to secrets by maintainers" turned on, but it's strange. If there are any issues, feel free to close this PR and copy the changes to your branch.

kitsonk commented 11 months ago

Maybe because I tried a rebase with a --force. 🤔