Closed stevestock closed 6 years ago
I guess so, I don't think these are huge issues. So what if the URLs re-direct? The dupe KiCad link is intentional.
Would be nice to check for 404s I guess. But those can just be temporary too.
I don’t think they are huge issues either, just minor improvements. Most redirects have a small impact to load time. Some, like link 01 ( linear.com to analog.com) could eventually be removed. Awesome_bot can be configured to ignore dupes.
On Fri, Apr 27, 2018 at 08:43 Kaspar Emanuel notifications@github.com wrote:
I guess so, I don't think these are huge issues. So what if the URLs re-direct? The dupe KiCad link is intentional.
Would be nice to check for 404s I guess. But those can just be temporary too.
— You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/monostable/awesome-electronics/issues/27#issuecomment-384958918, or mute the thread https://github.com/notifications/unsubscribe-auth/AE5-oUINbNv7BqSnRyFWtmylLZjYxmduks5tsxJagaJpZM4TpotP .
Sure, feel free to change these but I don't think I want CI complaining about people adding links which re-direct. Detecting dupes on PRs could be handy but only if it can be configured to ignore specific instances like the one we already have.
Doesn’t look like it can ignore specific instances. I’ll make a PR tonight for the issues it found. No worries if you don’t want to add an automatic CI check, up to you. Just a suggestion.
On Fri, Apr 27, 2018 at 09:07 Kaspar Emanuel notifications@github.com wrote:
Sure, feel free to change these but I don't think I want CI complaining about people adding links which re-direct. Detecting dupes on PRs could be handy but only if it can be configured to ignore specific instances like the one we already have.
— You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/monostable/awesome-electronics/issues/27#issuecomment-384964559, or mute the thread https://github.com/notifications/unsubscribe-auth/AE5-oRZtC8luxyTldwh6aV0UYOTImev0ks5tsxgAgaJpZM4TpotP .
awesome_bot output below. I can make a PR if you're interested. You also may want to set up Travis CI to check this automatically like several other awesome lists.