search

kitsteam / excalidraw-storage-backend

MIT License
12 stars 11 forks source link

New entrypoint script depends on Postgres being used #16

Open mckennajones opened 8 months ago

mckennajones commented 8 months ago

Cool project! Small issue I ran into when setting it up:

This PR #14 introduced an entrypoint script that uses the pg_isready command to wait for a postgres DB to come up. But, the documentation mentions that you can use any Keyv backend. In fact, the readme uses redis as an example. So the entrypoint should probably check for the DB being ready in a more generic way.

JannikStreek commented 8 months ago

@mckennajones uh thats right. As the dependencies are also connected to the chosen storage infrastructure, it might be best to prepare different or alternative docker files. I will think about it, thanks for raising this issue.

squatica commented 8 months ago

my 2 cents: the db container should have a healthcheck, and the storage container should depend on it. The healthcheck can then be different for redis or postgres.

sakonn commented 4 months ago

I was trying to deploy the container and got into the same issue since I want to use MySQL instead of Postgres. I have checked the pull request and seems fine to me. So, I would appreciate a new release with the fix.