search

kitsune-soc / kitsune

🦊 (fast) ActivityPub-federated microblogging
https://joinkitsune.org
Other
291 stars 19 forks source link

Rework error representation #517

Closed aumetra closed 2 months ago

aumetra commented 2 months ago

Closes #500

So, for the beginning I simply collapsed all the enum cases into a single "Other" case which has the representations of eyre::Report which is fairly compact from a memory usage standpoint.

That will drop the stack usage of errors down significantly (by at least 4x).

I'm still not convinced whether this is the correct solution.

aumetra commented 2 months ago

This will also get a revamp of parts of the OAuth2 code which is a bit horribly organized.

aumetra commented 2 months ago

kitsune-messaging is completely underutilized. Either we fix this up soon or we remove it.
I'd even opt to remove it for now. We don't need it yet. And in its current state, it's not really fit for usage anyway.

aumetra commented 2 months ago

Removed kitsune-messaging for now. We gotta re-add it once we implement WebSocket stuff for the streaming API.
But until then, bye bye!

aumetra commented 2 months ago

(well, damn. Of course coverage increases if we delete ~1k LoC)