kitsune-soc / kitsune

🦊 (fast) ActivityPub-federated microblogging
https://joinkitsune.org
Other
299 stars 19 forks source link

Update Meilisearch SDK #527

Closed aumetra closed 4 months ago

aumetra commented 4 months ago

New version of the Meilisearch SDK released, this time with support for custom HTTP clients.
In this PR we implement a custom HTTP client based on kitsune-http-client and hook it up to the client SDK.

That way we get rid of a bunch of dependencies that would otherwise be compiled into our binary, including OpenSSL.

This was also the main blocker why we didn't enable Meilisearch as a default feature. That means now we have it as a default feature, meaning all Kitsune instances should ship with Meilisearch support from now on.


Also, as a sidenote, the reason why utoipa-swagger-ui is pinned to 6.0.0 is because they introduced a build time dependency on reqwest and I really don't want to add that to the dependency tree.

I'm not entirely sure why they chose reqwest out of all HTTP clients, especially for a build step. ureq would have been totally sufficient (or minreq).

Well, maybe gonna check that out and potentially open a PR later.