kitt-browser / dev-tools

MIT License
0 stars 0 forks source link

Details box glitch: when iphone keyboard hides, details box covers most of the screen estate. #4

Open realyze opened 10 years ago

realyze commented 10 years ago
  1. go to xkcd.com
  2. click to expand HTML
  3. type 'he' into the search box. Wait for the first result to be highlighted (should happen in 1 second or so).
  4. click the "next result" arrow

the details box "stretches" and covers up most of the screen

screen shot 2014-07-29 at 09 50 04

realyze commented 10 years ago

So, this seems to be caused by the iphone keyboard - when the keyboard is visible, we're miscalculating the height of the screen (we're only considering the viewport without the keyboard). We should recalculate & redraw when the keyboard hides.

pavel-zdenek commented 10 years ago

Is the bug fixable with powers of extension (and DOM alone) or do you need some assistance from native side?

realyze commented 10 years ago

I think recalculating dimensions & redrawing on input field blur event ought to do the trick.

ghost commented 10 years ago

I can't believe redraw bugs still exist, that's the lowest kick.

ghost commented 10 years ago

I've tried triggering reflow after the keyboard disappears, but it doesn't seem to have any effect. I'm under the impression that Kitt somehow breaks the viewport height after keyboard is destroyed (only in special cases?).

ghost commented 10 years ago

Fixed by removing fixed positioning from the layout. https://github.com/kitt-browser/dev-tools/commit/54514c83ff0a8534630e63e65a6730ba729a2576 This may be out of Kitt's scope, exposing just pure webkit bugs, but maybe not, worth double checking if it's not on our side.