search

kitt-browser / translate

1 stars 0 forks source link

Destroy jq-scalebreaker popup on hide. #9

Closed realyze closed 10 years ago

realyze commented 10 years ago

The code is a little ugly, mostly because scalebreaker doesn't seem to support the "destroy to hide" paradigm. In particular, I don't know how to check if scalebreaker exists when it's not instantiated. Maybe some sort of static method on the scalebreaker factory could help here? (@filipnaumovic ?)

realyze commented 10 years ago

@filipnaumovic I assigned this PR to you, ping. :-)

ghost commented 10 years ago

You can get/check the widget instance like this $("body").data("salsitaScalebreaker") or $( "body" ).is( ":data( 'salsitaScalebreaker' )" ) or any other selector that aims for the data attribute, that's the main lead widget factory leaves.