search

kittoframework / kitto

Kitto is a framework for interactive dashboards written in Elixir
http://kitto.io/dashboards/sample
MIT License
956 stars 58 forks source link

Added railroading support with broadcast!/2 #110

Closed saulecabrera closed 7 years ago

saulecabrera commented 7 years ago

Adds the functionality discussed in #48

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 88.732% when pulling ed4e00320112de5b6e5a3dec0f37ae985fce78c0 on saulecabrera:broadcast-railroading-support into d91d015d92833358b625280b1d04ea20c1df6f57 on kittoframework:master.

saulecabrera commented 7 years ago

@Zorbash,

I'm not quite sure why the build is failing. I tried to reproduce the failures locally with the corresponding versions of Elixir & OTP, tried to re-trigger the build and the failures are not consistent.

1st failure: failed with OTP 18.3 & Elixir 1.4.0 (tried locally and I was able to reproduce the failure only once). 2nd failure: failed with OTP 18.3 & Elixir 1.3.4 (in the first run of the build this failure was not reported).

The failures are also reported in parts of the code not modified by this PR (at least directly).

Maybe I'm missing something here? Let me know if you have any inputs on this. I'll try to investigate further.

zorbash commented 7 years ago

@saulecabrera The build failures are caused by known flappy tests (which I'll try to fix during the weekend) and are not related to your MR (restarted the failed builds).

zorbash commented 7 years ago

Looks good to me. Thanks a lot for taking the time to submit this PR.