search

kittoframework / kitto

Kitto is a framework for interactive dashboards written in Elixir
http://kitto.io/dashboards/sample
MIT License
955 stars 58 forks source link

Fullscreen button #121

Closed nicholasRutherford closed 6 years ago

nicholasRutherford commented 7 years ago

Add a button to enable full screen mode. (Closes #19 )

The tiny icon in the top right: image

Test it out here!

The fullscreen API is a bit of mess across multiple browsers so it uses the fscreen library to handle the api call. This is the library recommended in the mozilla docs.

Since we want the button to show up when moving the mouse anywhere on the screen it listens to mouse move events on body. There doesn't seem to be a place for internal react components so while the button could be a component I think it makes more sense to just have the onClick listener.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 88.732% when pulling 348e6bfcff0b00da890b52a39a9c9ef7a1063a84 on nicholasRutherford:fullscreen-button into 9db6e2ae71caa9270e3124f9c937fdee3c476b73 on kittoframework:master.

zorbash commented 6 years ago

Merged! 9d8c391 Thanks @nicholasRutherford 🎊