fix to regular expressions on Erlang/OTP 20

kittoframework / kitto

Kitto is a framework for interactive dashboards written in Elixir

http://kitto.io/dashboards/sample

MIT License

956 stars 58 forks source link

fix to regular expressions on Erlang/OTP 20 #123

Closed volcov closed 6 years ago

volcov commented 6 years ago

Erlang/OTP 20 changed how regular expressions are matched, causing the name check to always fail with message:

** (Mix) Application name must start with a letter and have only lowercase letters, numbers and underscore, received: "hello_world"

;)

coveralls commented 6 years ago

Coverage remained the same at 88.732% when pulling 4e73fa407fb6fff67ef9e800501c416e9efb7245 on volcov:fix-mix-task-new into c3bdd31389dfc1b01abf4df478f9c886260bcc8d on kittoframework:master.

zorbash commented 6 years ago

Thanks a lot for spotting this. For reference, the same change has been made to phoenix (https://github.com/phoenixframework/phoenix/commit/fbb8f6004615b1c71e03caf68871d056d3cc94e9#diff-19b1aa473837241cbc876d3ad71bbb75R520).