Fixed webpack to close with kitto.server

kittoframework / kitto

Kitto is a framework for interactive dashboards written in Elixir

http://kitto.io/dashboards/sample

MIT License

956 stars 58 forks source link

Fixed webpack to close with kitto.server #124

Closed davejlong closed 5 years ago

davejlong commented 6 years ago

The --stdin flag wasn't added until a later version that the default for webpack-dev-server. This is meant as a hotfix for the larger task of updating Webpack.

coveralls commented 6 years ago

Coverage remained the same at 88.732% when pulling 79c4d096f43712b3e1f468ba5fd9124b91c5fbc0 on davejlong-patch-1 into ff4dbb53eb23ac030a7645e2ceafc08e09d30cff on master.

zorbash commented 6 years ago

@davejlong --stdin was added v1.15.0 see: https://github.com/webpack/webpack-dev-server/blob/v1.15.0/bin/webpack-dev-server.js#L26

This means https://github.com/kittoframework/kitto/commit/c3bdd31389dfc1b01abf4df478f9c886260bcc8d has broken the behaviour where killing mix kitto.server would stop the webpack-dev-server.

The easy fix is to bump webpack-dev-server to @1.15.0. Can you change it from this PR?