search

kittoframework / kitto

Kitto is a framework for interactive dashboards written in Elixir
http://kitto.io/dashboards/sample
MIT License
956 stars 58 forks source link

provide content-type for dashboard html #129

Closed leineu2016 closed 5 years ago

leineu2016 commented 5 years ago

We found that if we serve kitto dashboard behind nginx, chrome or safari will download the dashboard, rather than serving it as an html page. The reason is "content-type" of response is not properly set by kitto.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 88.636% when pulling 56b3155bd3a0eee35aa0e42cf9459b825bf48262 on leineu2016:master into e80c54b873ec6a444ae2f53e9975c0b1f8237159 on kittoframework:master.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 88.636% when pulling 56b3155bd3a0eee35aa0e42cf9459b825bf48262 on leineu2016:master into e80c54b873ec6a444ae2f53e9975c0b1f8237159 on kittoframework:master.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 88.636% when pulling 56b3155bd3a0eee35aa0e42cf9459b825bf48262 on leineu2016:master into e80c54b873ec6a444ae2f53e9975c0b1f8237159 on kittoframework:master.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 88.636% when pulling cb6f9cf3904d19bbe16763f0b31c91c67dd94741 on leineu2016:master into e80c54b873ec6a444ae2f53e9975c0b1f8237159 on kittoframework:master.

zorbash commented 5 years ago

Thanks for contributing. Mind adding a small test for this change?

zorbash commented 5 years ago

Thanks a lot @leineu2016