Consider Kitto.root when serving static assets

kittoframework / kitto

Kitto is a framework for interactive dashboards written in Elixir

http://kitto.io/dashboards/sample

MIT License

955 stars 58 forks source link

Consider Kitto.root when serving static assets #53

Closed chrta closed 7 years ago

chrta commented 7 years ago

This is necessary to use kitto in umbrella projects. See bug #52

zorbash commented 7 years ago

Hello, @chrta! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

chrta commented 7 years ago

On my local PC, mix test is working without issues...

coveralls commented 7 years ago

Coverage remained the same at 86.477% when pulling cd29a0f44a5cbc58bc9b80481aa87ccb3bb31be1 on chrta:bugfix-for-#52 into 7eeda801218c9af3c76da8cc51478ff5d592b616 on kittoframework:master.

zorbash commented 7 years ago

Looks good. The test failure was due to a flawed test which has to be re-written.