search

kittoframework / kitto

Kitto is a framework for interactive dashboards written in Elixir
http://kitto.io/dashboards/sample
MIT License
956 stars 58 forks source link

Force fs to use rebar3 manager to fix error. See sync/fs#33 #67

Closed davejlong closed 7 years ago

davejlong commented 7 years ago

Fixes #65. An unreleased version of fs forces the rebar3 manager to compile the dependency. See https://github.com/synrc/fs/issues/33

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 87.162% when pulling 04c8f00cd4f33a167524abf3cd13c166f1d6870a on code-reloading into 184cc56ccdadcb49d32b66c20dd45216e17823e2 on master.

zorbash commented 7 years ago

The best thing to do now is to raise some awareness on https://github.com/synrc/fs/issues/24 and wait. If there's no response we should consider pushing a package from our fork.

davejlong commented 7 years ago

I started playing with writing a fairly simple wrapper for the fswatch library. If it works, setup would be easier as fswatch is a pure C implementation which works on Mac, *nix, Microsoft.

zorbash commented 7 years ago

@davejlong Can you confirm that fs@2.12 works on the mac?

zorbash commented 7 years ago

We have a confirmation that 2.12.0 fixes the issue. See: https://github.com/kittoframework/kitto/issues/65#issuecomment-268254803

Merging this. Thanks @davejlong for the fantastic work on finding the root cause of this issue and doing whatever needed to resolve it. :clap: :clap:

zorbash commented 7 years ago

@davejlong I've seen fswatch and it seems like a really promising attempt to make fs notifications cross-platform. What bothers me it's lack of packaging for Linux (see: https://github.com/emcrisostomo/fswatch#installation). No deb packages yet :-/

Also there's a change that fswatch will be supported through fs, see: https://github.com/synrc/fs/issues/17