Testing/installation test

kittoframework / kitto

Kitto is a framework for interactive dashboards written in Elixir

http://kitto.io/dashboards/sample

MIT License

956 stars 58 forks source link

Testing/installation test #71

Closed JanStevens closed 7 years ago

JanStevens commented 7 years ago

This adds a basic test fixing #35 and also attempts to fix #16 using delta's

I mimicked the way phoenix is testing its installer task. The only problem is that we don't generate a test directory. We don't provide any way for testing jobs (currently).

I didn't test that every file got written, rather I asserted that we could load the sample dashboard

coveralls commented 7 years ago

Coverage remained the same at 87.162% when pulling bcf21ad576d3ad0b3d9b8d40ab93ff9adbb73106 on playpasshq:testing/installation-test into c927a709af51183ea652a9c726fc34f0497a1deb on kittoframework:master.

zorbash commented 7 years ago

Please split this in 2 PRs one for #16 and another for the installer tests.

zorbash commented 7 years ago

Nevermind about https://github.com/kittoframework/kitto/pull/71#issuecomment-268378965 I commited (attributed to you) as 7dc8af7a0

Just remove https://github.com/kittoframework/kitto/pull/71/commits/8cb1d41671d2dbf63fe2f38e70f471495b137802 from this PR.

coveralls commented 7 years ago

Coverage remained the same at 87.162% when pulling 725682c45692ac28750b888d3904da343e50dad0 on playpasshq:testing/installation-test into c927a709af51183ea652a9c726fc34f0497a1deb on kittoframework:master.

coveralls commented 7 years ago

Coverage remained the same at 87.162% when pulling 2ea09e380c2473998c6a78831fe736e6deb76f0c on playpasshq:testing/installation-test into 7dc8af7a032a234f5597747c16d4a5b56e172291 on kittoframework:master.

zorbash commented 7 years ago

Cherry-picked this as 46d3f1744e1e

Note: Code for the test is adapted from https://github.com/phoenixframework/phoenix/blob/v1.2.1/test/mix/tasks/phoenix.new_test.exs

Thanks @JanStevens :+1: