Ignore conflicting module names in tests - Githubissues

kittoframework / kitto

Kitto is a framework for interactive dashboards written in Elixir

http://kitto.io/dashboards/sample

MIT License

955 stars 58 forks source link

Ignore conflicting module names in tests #81

Closed davejlong closed 7 years ago

davejlong commented 7 years ago

If the Kitto installer is already installed then running the test suite will generate the following warning:

warning: redefining module Mix.Tasks.Kitto.New (current version loaded from /Users/david/.kiex/mix/archives/elixir-1.3.4/kitto_new-0.3.1/kitto_new-0.3.1/ebin/Elixir.Mix.Tasks.Kitto.New.beam)
  installer/lib/kitto_new.ex:1

The change hides these warning in tests. If needed we can disable the warning only in test/mix/tasks/kitto.new_test.exs.

coveralls commented 7 years ago

Coverage remained the same at 87.162% when pulling 4a2694bf480e2c5460ee4644c032b8a3b979128a on test-warning into ad560015d71a904d57ced912e54b333f1e743e95 on master.

zorbash commented 7 years ago

@davejlong Let's silence the warnings only for test/mix/tasks/kitto.new_test.exs. The module redefinition warning is useful and we shouldn't accidentally silence valid warnings.

coveralls commented 7 years ago

Coverage decreased (-0.9%) to 86.293% when pulling 6290acc44534aa4f52e590803b754003f606af97 on test-warning into ad560015d71a904d57ced912e54b333f1e743e95 on master.

coveralls commented 7 years ago

Coverage decreased (-0.9%) to 86.293% when pulling 6290acc44534aa4f52e590803b754003f606af97 on test-warning into ad560015d71a904d57ced912e54b333f1e743e95 on master.

coveralls commented 7 years ago

Coverage decreased (-0.9%) to 86.293% when pulling 6290acc44534aa4f52e590803b754003f606af97 on test-warning into ad560015d71a904d57ced912e54b333f1e743e95 on master.

coveralls commented 7 years ago

Coverage remained the same at 86.293% when pulling 7a44f71a48a6819dc9716cc77707837e1ae9fc19 on test-warning into f89ec58e1adcc99f8de85dfba04110944a16c14d on master.