renamed text job to phrases for easier comprehension - Githubissues

kittoframework / kitto

Kitto is a framework for interactive dashboards written in Elixir

http://kitto.io/dashboards/sample

MIT License

956 stars 58 forks source link

renamed text job to phrases for easier comprehension #85

Closed mackenza closed 7 years ago

mackenza commented 7 years ago

when I first looked at Kitto I looked at the text widget and didn't quite grok the relationship between a widget, a job and the dashboard. Part of this was because the job was named text as was the widget (well Text I guess technically).

I simply renamed text.exs to phrases.exs and changed the installer template so now the text widget on the sample dashboard is similar to the other widgets where the widget name is different than the job name (`data-source="phrases" in the dashboard).

It's a small change but I think could help.

mackenza commented 7 years ago

some more background can be found on Gitter where @davejlong and I discussed this topic. Thanks Dave!

coveralls commented 7 years ago

Coverage increased (+0.9%) to 86.88% when pulling 758d3455c22f33e1b9078a7541070700cf904bd5 on mackenza:rename-text-job into 261f5080de47f73af030aebe906d8fe13d5ed42a on kittoframework:master.

coveralls commented 7 years ago

Coverage increased (+0.9%) to 86.88% when pulling 758d3455c22f33e1b9078a7541070700cf904bd5 on mackenza:rename-text-job into 261f5080de47f73af030aebe906d8fe13d5ed42a on kittoframework:master.

coveralls commented 7 years ago

Coverage increased (+0.9%) to 86.88% when pulling 758d3455c22f33e1b9078a7541070700cf904bd5 on mackenza:rename-text-job into 261f5080de47f73af030aebe906d8fe13d5ed42a on kittoframework:master.

coveralls commented 7 years ago

Coverage increased (+0.9%) to 86.88% when pulling 758d3455c22f33e1b9078a7541070700cf904bd5 on mackenza:rename-text-job into 261f5080de47f73af030aebe906d8fe13d5ed42a on kittoframework:master.

mackenza commented 7 years ago

@zorbash if you want me to clean this up with a new PR let me know. I tested my initial changes but it was working because I hadn't changed the dashboard and job to match. Fixed now.

coveralls commented 7 years ago

Coverage increased (+0.9%) to 86.88% when pulling 08fddbccf7caa64631a1ede215f3f60cebc0db4f on mackenza:rename-text-job into 261f5080de47f73af030aebe906d8fe13d5ed42a on kittoframework:master.

zorbash commented 7 years ago

Merged as 09bc604c3348467ca46c05df4163e8c8c2a57242 Thanks @mackenza