search

kittoframework / kitto

Kitto is a framework for interactive dashboards written in Elixir
http://kitto.io/dashboards/sample
MIT License
955 stars 58 forks source link

Elixir 1.4 warnings #89

Closed davejlong closed 7 years ago

davejlong commented 7 years ago

Elixir 1.4 introduces a new compiler warning when methods are called with no arguments and no parentheses. This should be a fairly simple (just a bit tedious) issue to fix.

You can get all the warnings by running mix compile --force. All warnings currently on master:

$ mix compile --force
warning: variable "description" does not exist and is being expanded to "description()", please use parentheses to remove the ambiguity or change the variable name
  mix.exs:10

warning: variable "package" does not exist and is being expanded to "package()", please use parentheses to remove the ambiguity or change the variable name
  mix.exs:11

warning: variable "deps" does not exist and is being expanded to "deps()", please use parentheses to remove the ambiguity or change the variable name
  mix.exs:12

Compiling 23 files (.ex)
warning: variable "ip" does not exist and is being expanded to "ip()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto.ex:28

warning: variable "port" does not exist and is being expanded to "port()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto.ex:28

warning: variable "ip" does not exist and is being expanded to "ip()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto.ex:29

warning: variable "port" does not exist and is being expanded to "port()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto.ex:29

warning: variable "reload_code?" does not exist and is being expanded to "reload_code?()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/code_reloader.ex:19

warning: variable "lib_rexp" does not exist and is being expanded to "lib_rexp()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/code_reloader.ex:77

warning: variable "jobs_rexp" does not exist and is being expanded to "jobs_rexp()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/code_reloader.ex:78

warning: variable "auth_token" does not exist and is being expanded to "auth_token()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/plugs/authentication.ex:48

warning: variable "auth_token" does not exist and is being expanded to "auth_token()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/plugs/authentication.ex:52

warning: variable "make_ref" does not exist and is being expanded to "make_ref()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/notifier.ex:17

warning: variable "make_ref" does not exist and is being expanded to "make_ref()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/notifier.ex:18

warning: variable "cache" does not exist and is being expanded to "cache()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/notifier.ex:38

warning: variable "connections" does not exist and is being expanded to "connections()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/notifier.ex:48

warning: variable "updated_at" does not exist and is being expanded to "updated_at()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/notifier.ex:62

warning: variable "notifier_connections" does not exist and is being expanded to "notifier_connections()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/notifier.ex:69

warning: variable "notifier_cache" does not exist and is being expanded to "notifier_cache()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/notifier.ex:77

warning: variable "notifier_cache" does not exist and is being expanded to "notifier_cache()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/notifier.ex:82

warning: variable "notifier_cache" does not exist and is being expanded to "notifier_cache()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/notifier.ex:87

warning: variable "notifier_connections" does not exist and is being expanded to "notifier_connections()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/notifier.ex:92

warning: variable "notifier_connections" does not exist and is being expanded to "notifier_connections()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/notifier.ex:97

warning: variable "self" does not exist and is being expanded to "self()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/runner.ex:22

warning: variable "self" does not exist and is being expanded to "self()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/runner.ex:86

warning: variable "job_files" does not exist and is being expanded to "job_files()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/runner.ex:134

warning: variable "jobs_dir" does not exist and is being expanded to "jobs_dir()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/runner.ex:139

warning: variable "minval" does not exist and is being expanded to "minval()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/backoff_server.ex:42

warning: module attribute @max_restarts was set but never used
  lib/kitto/runner.ex:11

warning: variable "maxval" does not exist and is being expanded to "maxval()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/backoff_server.ex:42

warning: variable "minval" does not exist and is being expanded to "minval()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/backoff_server.ex:43

warning: variable "maxval" does not exist and is being expanded to "maxval()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/backoff_server.ex:43

warning: variable "maxval" does not exist and is being expanded to "maxval()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/backoff_server.ex:44

warning: variable "backoff_module" does not exist and is being expanded to "backoff_module()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/stats_server.ex:62

warning: variable "backoff_module" does not exist and is being expanded to "backoff_module()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/stats_server.ex:71

warning: variable "backoff_enabled?" does not exist and is being expanded to "backoff_enabled?()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/stats_server.ex:82

warning: variable "backoff_module" does not exist and is being expanded to "backoff_module()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/stats_server.ex:82

warning: variable "templates_path" does not exist and is being expanded to "templates_path()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/view.ex:45

warning: variable "development_assets_url" does not exist and is being expanded to "development_assets_url()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/router.ex:93

warning: variable "scss" does not exist and is being expanded to "scss()", please use parentheses to remove the ambiguity or change the variable name
  lib/mix/tasks/generators/kitto.gen.widget.ex:34

warning: variable "javascript" does not exist and is being expanded to "javascript()", please use parentheses to remove the ambiguity or change the variable name
  lib/mix/tasks/generators/kitto.gen.widget.ex:35

warning: variable "default_dashboard" does not exist and is being expanded to "default_dashboard()", please use parentheses to remove the ambiguity or change the variable name
  lib/kitto/router.ex:160

warning: variable "watch_assets?" does not exist and is being expanded to "watch_assets?()", please use parentheses to remove the ambiguity or change the variable name
  lib/mix/tasks/kitto.server.ex:22

warning: variable "validate_watcher" does not exist and is being expanded to "validate_watcher()", please use parentheses to remove the ambiguity or change the variable name
  lib/mix/tasks/kitto.server.ex:30

warning: variable "asset_server_host" does not exist and is being expanded to "asset_server_host()", please use parentheses to remove the ambiguity or change the variable name
  lib/mix/tasks/kitto.server.ex:32

warning: variable "asset_server_port" does not exist and is being expanded to "asset_server_port()", please use parentheses to remove the ambiguity or change the variable name
  lib/mix/tasks/kitto.server.ex:32

warning: variable "watcher_bin" does not exist and is being expanded to "watcher_bin()", please use parentheses to remove the ambiguity or change the variable name
  lib/mix/tasks/kitto.server.ex:34

warning: variable "watcher" does not exist and is being expanded to "watcher()", please use parentheses to remove the ambiguity or change the variable name
  lib/mix/tasks/kitto.server.ex:35

warning: variable "asset_server_host" does not exist and is being expanded to "asset_server_host()", please use parentheses to remove the ambiguity or change the variable name
  lib/mix/tasks/kitto.server.ex:36

warning: variable "watcher_exists?" does not exist and is being expanded to "watcher_exists?()", please use parentheses to remove the ambiguity or change the variable name
  lib/mix/tasks/kitto.server.ex:41

warning: variable "watcher_bin" does not exist and is being expanded to "watcher_bin()", please use parentheses to remove the ambiguity or change the variable name
  lib/mix/tasks/kitto.server.ex:42

warning: variable "watcher_bin" does not exist and is being expanded to "watcher_bin()", please use parentheses to remove the ambiguity or change the variable name
  lib/mix/tasks/kitto.server.ex:51

warning: variable "watcher" does not exist and is being expanded to "watcher()", please use parentheses to remove the ambiguity or change the variable name
  lib/mix/tasks/kitto.server.ex:54

warning: variable "iex_running?" does not exist and is being expanded to "iex_running?()", please use parentheses to remove the ambiguity or change the variable name
  lib/mix/tasks/kitto.server.ex:56
fusillicode commented 7 years ago

If it's ok I would like to take this issue 😊

I think I can deliver a PR during this Saturday.

fusillicode commented 7 years ago

One question. I've opened another issue (i.e. #91) that is strongly related to the current one. Should I address it with a proper branch and PR or should I consider it part of the current issue (i.e. #89)?

zorbash commented 7 years ago

@fusillicode I suggest that you create a PR resolving both issues.

fusillicode commented 7 years ago

@Zorbash perfect thank you, I'll try to update the one I've already open (i.e. #90) to fix the current issue.

fusillicode commented 7 years ago

@Zorbash PR #90 updated to consider also the tests 😉

fusillicode commented 7 years ago

Given this merged PR I think that this issue could be considered closed 🤗