search

kittoframework / kitto

Kitto is a framework for interactive dashboards written in Elixir
http://kitto.io/dashboards/sample
MIT License
956 stars 58 forks source link

Add empty parentheses to silence Elixir 1.4 warnings #90

Closed fusillicode closed 7 years ago

fusillicode commented 7 years ago

This PR addresses the issue #89 and aims to solve all the warnings related to the missing empty parentheses that are raised at compilation time.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 86.88% when pulling ee2c34cd45ebdcf7962710acc5c40e06526f029d on fusillicode:fix-elixir-1.4-warnings into a44719866e85bd6659ca444de092dd49637ccabf on kittoframework:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 86.88% when pulling 0a2ed1e00a27b91beb02a832145331cc0314783a on fusillicode:fix-elixir-1.4-warnings into a44719866e85bd6659ca444de092dd49637ccabf on kittoframework:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 86.726% when pulling e69af8159cd0597779c5b43f1bffb655aeed34e8 on fusillicode:fix-elixir-1.4-warnings into a44719866e85bd6659ca444de092dd49637ccabf on kittoframework:master.

zorbash commented 7 years ago

Thanks a lot @fusillicode :heart:

fusillicode commented 7 years ago

I'm the one who should be thankful to you @Zorbash (and to all Kitto creators and maintainers) 🤗

You're doing an awesome job! Keep on! 👌😎

I hope to be able to contribute to more "important" issues in the future 😄