No option to set static custom ip settigs

kittoku / Open-SSTP-Client

Open SSTP Client for Android

MIT License

402 stars 104 forks source link

No option to set static custom ip settigs #58

Closed AMajor-C closed 1 year ago

AMajor-C commented 2 years ago

Please add a feature to set static ip settings

mfoolady commented 2 years ago

You cannot specify IP addresses directly to use the SSTP connection

AMajor-C commented 2 years ago

You cannot specify IP addresses directly to use the SSTP connection

Really ? say it to built-in client for windows or Mikrotik's ROS

mfoolady commented 2 years ago

Since 2016, the CA/Browser Forum made SSL certificates for private IP/reserved IP and local server name with a non-public domain name suffix invalid and asked certificate authorities to revoke any such SSL certificates. Because such reserved IP addresses and local server names (intranet) are not unique, they are easy to impersonate by attackers to commit man-in-the-middle attacks and get unauthorized access to the data. Hence, publicly trusted certificate authorities can no longer secure such IPs. You can get a self-signed SSL certificate for private IPs and intranet addresses, though.

maziarkabir commented 2 years ago

But I use Softether clients with Ip. Its configured only SSTP!

mfoolady commented 2 years ago

Softether VPN protocol (ethernet over HTTPS) is different from MS-SSTP VPN

xumingxin7398 commented 2 years ago

I want this feature too, other clients support ip settings without a domain.

kittoku commented 2 years ago

Which address will be assigned should be handled by a server side. And this kind of feature is not implemented in Windows-built-in client and SoftEther's.

AMajor-C commented 2 years ago

Which address will be assigned should be handled by a server side. And this kind of feature is not implemented in Windows-built-in client and SoftEther's.

Srsly ? Then what is that ?

kittoku commented 2 years ago

My bad. I didn't see the lower layer.

But I am still hesitating to implement a feature like this. I think that an IP address should be assigned according to an user's ID (like MAC address in DHCP) and I don't want to add a feature for maintainability unless it's needed by significantly many users.

AMajor-C commented 2 years ago

My bad. I didn't see the lower layer.

But I am still hesitating to implement a feature like this. I think that an IP address should be assigned according to an user's ID (like MAC address in DHCP) and I don't want to add a feature for maintainability unless it's needed by significantly many users.

Sounds nice BUT softether's virtualnat doesnt support username-ip binding or mac-ip binding it is cause why i requested the feature.

kittoku commented 2 years ago

Please try osc-static.apk and use Static IPv4 Address preference.

AMajor-C commented 2 years ago

Please try osc-static.apk and use Static IPv4 Address preference.

I have tested and it works good thak you.

AMajor-C commented 2 years ago

BTW can you add option 33 and 252 accepting from server's dhcp ? 33 - pushes routes 252 - proxy settings

kittoku commented 2 years ago

This client doesn't have DHCP stack. So maybe I couldn't do that.

AMajor-C commented 2 years ago

This client doesn't have DHCP stack. So maybe I couldn't do that.

Oh got it. I see you also added http proxy option that's nice what do you think about socks?

kittoku commented 1 year ago

I won't implement it at least this time. I need knowledge, time and necessity.

Please notice we are getting off-topic.