search

kittsville / GifSound-2

Abandoned remake of gifsound.com with modular media plugins and no server-side code
https://sci1.uk/GifSound-2/
GNU General Public License v2.0
4 stars 1 forks source link

Add reading/writing state from/to URL #3

Closed kittsville closed 8 years ago

kittsville commented 8 years ago

Progress is on the url-params branch

kittsville commented 8 years ago

The branch can currently read a gif, sound and start time from the URL and choose the highest priority appropriate plugins for both media types. The branch cannot write to the URL.

Error handling needs some headway, along with TheForm's submission processing, before writing to the URL can happen. HTML5 History API and a whole bunch of new code will be needed to implement this so I want to refactor things a bit first.

kittsville commented 8 years ago

It'll probably be a few more days until I come back to this.

kittsville commented 8 years ago

Because all my local sites are /localhost/site/ using an absolute URL creates an invalid URL. While it's perfectly sensible code for gifsound2.com it would mean I'd need to either change my local configuration, add local config detecting code or remove the <base> tag that makes relative URLs go to /assets.

I guess the base tag only saves a few bytes anyway so I should probably remove it.

kittsville commented 8 years ago

The site is giving an error on loading a GifSound from URL params. TheGif should be being set but isn't.

kittsville commented 8 years ago

Back/Forward navigation handling also needs adding. WP-Librarian's use of the History API should make implementing this pretty easy.

kittsville commented 8 years ago

I might create an issue later specifically for setting the form's values given the URL params. It'd require having plugins rebuild URLs from params (which might not be possible for all plugins in the future) so it'll be enough of a topic to warrant its own issue.