kittykatattack / ga

The world's tiniest, cutest and funnest game engine
453 stars 85 forks source link

spritesheet having frames of different width and height. #19

Closed qsrahman closed 9 years ago

qsrahman commented 9 years ago

If a spritesheet contains frames of different width and height it will not be rendered correctly unless the changed is made.

kittykatattack commented 9 years ago

Great catch, thanks!

kittykatattack commented 9 years ago

This change actual made it in to the production code for the new Advanced book that's coming out within the next month:

http://www.apress.com/advanced-game-design-with-html5-and-javascript?gtmf=s

I'd like to give you an acknowledgement in the book's preface for your help. Is this text OK?:

"Thanks to Sami ur Rahman Qazi for a suggested improvement on how the gotoAndStop method handles texture atlas frames of differing sizes in Chapter 4."

qsrahman commented 9 years ago

Thanks :+1:

kittykatattack commented 9 years ago

Cool, it's done :)