kittykatattack / hexi

Make games the fun way!
MIT License
555 stars 83 forks source link

Arrow keys gone? #22

Open icarito opened 7 years ago

icarito commented 7 years ago

Hi, Docs say this exists, but it's commented out in the code: https://github.com/kittykatattack/hexi/blob/1de3223415b2150e0b5556195c10e3004990b3ad/src/core.js#L697

Would be nice to have, IMHO. Regards, Sebastian

kittykatattack commented 7 years ago

Yes! I actually don't remember why I removed that feature... but I remember it was for good reason 😄 It was kind of a cute shortcut, but in my own projects I've only ever used the long-form way because I preferred being more explicit about the exact ascii code name I was using. There's also an arrowControl super-shortcut you use, which auto-configures the arrow keys for you, as in here:

https://github.com/kittykatattack/hexi/blob/master/examples/src/keyboardMovement.js

mattlima commented 7 years ago

Love the package but silent deprecations like this really hurt usability. My team just wasted 30 min trying to figure out why the code wasn't working in the absence of a CHANGELOG.md.

kittykatattack commented 7 years ago

@mattlima Sorry about that - those features were gone for a very long time. And, really, I had no idea anyone besides me as using this library. 😄

Also, very importantly, I would not yet recommend anyone use Hexi for production code (code that your business depends on) until it reaches a stable v1.0 release. Please see this issue: https://github.com/kittykatattack/hexi/issues/5

mattlima commented 7 years ago

@kittykatattack Thanks, and I hear you. I'd be happy to help you maintain the package. It has been very useful for us and there's clearly been a lot of effort invested in it already; seems a shame to not take it the last mile to 1.0.

kittykatattack commented 7 years ago

@mattlima I would love the help - I'll add you as a collaborator!

I had been working almost full time on this project for about a year, but as you've noticed I'm super-busy on a ton of other projects at the moment and am not able to maintain Hexi as well as I should.

Here are just a couple of thoughts:

Thanks again for your interest in helping!