search

kittykatattack / hexi

Make games the fun way!
MIT License
551 stars 83 forks source link

OSX: g.start() => browser reload keyboard shortcut no longer works #29

Open gamecubate opened 7 years ago

gamecubate commented 7 years ago

On OSX, browser refresh shortcut (command-r) becomes non-functional once the hexi game loop (e.g., g.start()) is launched. Witnessed on OSX 10.11.5 with both Chrome 54+ and Firefox 49+.

gamecubate commented 7 years ago

I traced this down to the tink module and its event.preventDefault() call inside the keyboard handler function. Should I transfer this issue over there?

kittykatattack commented 7 years ago

Thanks for reporting this!!! That's OK, we can track it here. Could you list the code that you found to be problematic?

gamecubate commented 7 years ago

Not sure I found the right code. Disabling the keyup and down listeners set up by hex.min.js in Chrome's dev tools does make the problem go away. Event capture and/or bubbling at play.

BTW, not a huge deal, but does slow down development.

kittykatattack commented 7 years ago

Ok, that's weird.