search

kittykatattack / hexi

Make games the fun way!
MIT License
551 stars 83 forks source link

Permissive licenses for all the modules (as source is not included in download) #43

Open JamesCraster opened 6 years ago

JamesCraster commented 6 years ago

I'd love to help out with Hexi, but some of the modules (Charm, Sprite Utilities and Sound.js, maybe more?) don't have licenses, so I cannot modify them or distribute them at all. If you could add a license of your choice to each of the modules that would be great! (The source for the modules isn't included when you download the zip from this repository, so the modules are not covered by MIT. The /src folder is full of empty folders. Edit: I think the best way would be to give each module a license individually.) Thanks.

kittykatattack commented 6 years ago

Thanks @JamesCraster! The submodules are licensed (see their repos), but I didn't know that the licences had to travel with the compiled code up to the parent module. This probably won't be something I'll be able to do soon, but if you can suggest a quick fix, please let me know.

JamesCraster commented 6 years ago

Edit: I don't think that all the submodules are licensed, and that is the problem. Unless I'm missing something.

I've been looking around the repositories of both Sprite Utilities and Sound.js, and I can't find a license for either. And Charm seems to be licensed twice in its repository (once with MIT, once with a license you wrote. I'm not sure if multiple licenses is a problem - maybe choose one?) The other modules are licensed under MIT in their repositories(so they are fine), but I can't modify or distribute either Sprite Utilities or Sound.js as they are now.

As an aside, I think that the licenses don't need to travel with the compiled code. The compiled code has been released under MIT, because it is in this repo. The source code for the modules is not in this repo, so that source code is not released under MIT (unless you have given the code a license individually in their own repositories, as you have with most.) So I can use all the modules, modify and distribute almost all, but I cannot modify/distribute Sprite Utilities or Sound.js.

If you could add a license to the repositories of Sprite Utilities and Sound.js, that would be lovely. Unless I have overlooked a license somewhere.

Edit: you may want to choose a license for Charm too. Edit: I understand, my first post was ambiguous: Source code is the problem. The source code for Sprite Utilities and Sound.js is not licensed. All the compiled code in this repo is MIT, so compiled code is fine. I should really have been more clear.