search

kitware-resonant / django-auth-style

Django template styling for django-allauth and django-oauth-toolkit.
Apache License 2.0
3 stars 1 forks source link

Global button styles #37

Closed danlamanna closed 5 months ago

danlamanna commented 3 years ago

@jtomeck Am I right in reading this code? https://github.com/girder/django-girder-style/blob/0429b624b12600a745a56c0ca1ab3c499de8f17a/tailwind/src/styles.scss#L56

It appears as though I can't have a button downstream that is unstyled? Can we remove this?

jtomeck commented 3 years ago

That's a good point, I didn't think about that when implementing it. Yeah, remove it.

danlamanna commented 3 years ago

But also inputs and forms and others? Won't this break all of the login/signup stuff? I think this is kind of what @brianhelba and I were wondering around the intended use of this.

jtomeck commented 3 years ago

This is a helper so you don't have to type 10-15 tailwind classes multiple times on every button sitewide. I think it's safe to remove button and keep .button and in the code just use <button class="button">. You don't have to use the helper class at all. You can write your own button styles with tailwind classes, but I think the helper needs to be there in case you don't want to do that.

Am I not understanding what you're asking?

brianhelba commented 5 months ago

Obsoleted by #85.