search

kitware-resonant / django-auth-style

Django template styling for django-allauth and django-oauth-toolkit.
Apache License 2.0
3 stars 1 forks source link

Release of django-allauth 0.58 breaks templates #79

Open brianhelba opened 2 months ago

brianhelba commented 2 months ago

django-allauth 0.58 includes the following change:

Refactored the built-in templates, with the goal of being able to adjust the look and feel of the whole project by only overriding a few core templates. This approach allows you to achieve visual results fast, but is of course more limited compared to styling all templates yourself. If your project provided its own templates then this change will not affect anything, but if you rely on (some of) the built-in templates your project may be affected.

The changes were made primarily in https://github.com/pennersr/django-allauth/pull/3466 .

At a minimum, the styled pages of django-auth-style should be reviewed, to see if anything is broken.

Additionally, we should investigate whether it's possible to change this library to apply styles only to the core templates of django-allauth, which may reduce the surface area and maintenance burden of this library significantly.

brianhelba commented 2 months ago

We should consider this library to be soft-broken by django-allauth >= 0.58.

However, I'm not sure whether it makes sense to pin the requirements accordingly, since this will force downstreams to adopt an older version of an important library, just to prevent some style bugs.

brianhelba commented 2 months ago

One breaking change is that the link to the account_reset_password page within login.html was removed and instead added as help_text on the password field of LoginForm.

This causes the link to now display twice, with django-auth-style.

The easiest fix is to remove corresponding HTML from django-auth-style, to match the upstream version. However, this will require that django-auth-style depend on django-allauth >= 0.58, which might introduce other breakages.