search

kitware-resonant / django-composed-configuration

Turnkey Django settings for data management applications.
Apache License 2.0
9 stars 2 forks source link

New GeoDjangoMixin configuration #141

Closed banesullivan closed 3 years ago

banesullivan commented 3 years ago

This configuration is used across all projects that install the RGD apps and any projects hoping to use geodjango.

https://github.com/ResonantGeoData/RD-OpenGeo/blob/98aff6fe06348ba1556d017e2ded5e3dd17c1265/opengeo/settings.py#L16-L36

Should we migrate this upstream to composed-configurations so that new projects can more easily utilize this and so that we only have to maintain it in one spot?

Other places it appears:

brianhelba commented 3 years ago

I don't think this is in scope for Composed-Configuration, as it would certainly be an optional mixin, and I think it's too ambitious to support mix-and-match downstream composition of mixins officially (of course, it's expected and acceptable that downstreams will choose to do this in an unsupported way).

Any downstream package like RGD should be able to depend on Composed-Configuration and publish their own mixin classes though. If something is blocking that, please file a bug, so it can be addressed directly.

Otherwise, I think these particular settings are too particular to RGD to be useful upstream. I'm closing this accordingly, but feel free to comment if you have other thoughts.