As written, the change here in the _HerokuMixin is backwards incompatible and will break any installations using CloudAMQP rather than the Redis addon. If we wanted a backward compatible version of this, we'd need fallback logic (likely in a @property) to check for either environment variable (with some order of precedence we could decide on).
For local development, no code changes are needed in this library to support using redis as the broker.
Note also that this PR doesn't go as far as to enable a celery results backend. If we switch to Redis, it's officially more suitable as a result backend than AMQP, but that's a more controversial change than I want for the scope of this RFC.
As written, the change here in the
_HerokuMixinis backwards incompatible and will break any installations using CloudAMQP rather than the Redis addon. If we wanted a backward compatible version of this, we'd need fallback logic (likely in a@property) to check for either environment variable (with some order of precedence we could decide on).For local development, no code changes are needed in this library to support using redis as the broker.
Note also that this PR doesn't go as far as to enable a celery results backend. If we switch to Redis, it's officially more suitable as a result backend than AMQP, but that's a more controversial change than I want for the scope of this RFC.