search

kitware-resonant / django-resonant-utils

Django utilities for data management applications.
Apache License 2.0
2 stars 1 forks source link

Use an integer expiration for signing S3 urls #20

Closed danlamanna closed 3 years ago

danlamanna commented 3 years ago

generate_presigned_url takes an int for S3, and a timedelta for MinIO. Without an int, the signatures generated are invalid.

https://github.com/boto/botocore/blob/717eb38a99d0f3eed9648abd62184fbc6a7947ef/botocore/signers.py#L259-L261

brianhelba commented 3 years ago

Checks aren't running because this is a branch on a fork. This change is minor enough to verify without CI, so I'll merge it.