kitware-resonant / dkc-next

Apache License 2.0
3 stars 0 forks source link

Treebeard tuning #12

Closed zachmullen closed 4 years ago

zachmullen commented 4 years ago

Fixes #5.

I found some nasty stuff going on when trying to use a larger alphabet, I'm documenting my tribulations here: https://github.com/django-treebeard/django-treebeard/issues/174

Short version of the story is, base62 works fine, and I just upped the steplen from 4 to 5 so that we can have a ridiculously high limit for subfolders.

zachmullen commented 4 years ago

Don't merge this yet. I figured out the issue with the alphabet and it's not a problem in the library itself it's a bug in the library itself. Namely, the value that is set back on the path after saving is not correct, which causes our mock_db script to fail.

zachmullen commented 4 years ago

Pursuing this deeper, the issue seems to be in reorder_nodes_before_add_or_move in treebeard's MP tree impl.