Incorrect logic in REST-layer folder name validator

kitware-resonant / dkc-next

Apache License 2.0

3 stars 0 forks source link

Incorrect logic in REST-layer folder name validator #162

Closed zachmullen closed 3 years ago

zachmullen commented 3 years ago

This UniqueTogetherValidator has incorrect logic. Namely, if a root folder exists with a given name, that name cannot be used for any other folder, regardless of whether it's a root or not.

Steps to reproduce:

Create root folder named "foo".
Create a non-root folder anywhere else named "foo".

Expectation: operation succeeds.
Actual result: HTTP 400 with error "A root folder with that name already exists."

zachmullen commented 3 years ago

@brianhelba I pushed this branch containing a failing test case (3e63da72c93937d9b8f70c5262720d1ac1b0c00b), feel free to take over that branch.

brianhelba commented 3 years ago

@zachmullen Working on this now.