search

kitze / custom-react-scripts

[DEPRECATED, use customize-cra] Allow custom config for create-react-app without ejecting
https://custom-react-scripts.netlify.com
MIT License
993 stars 97 forks source link

.env options have no effect due to incorrect syntax #114

Open geloescht opened 6 years ago

geloescht commented 6 years ago

All options set by editing the .env file that is created by default have no effect whatsoever. The reason is, that the environment variables include semicolons at the end of each line. But config/custom-react-scripts/config.js expects the value "false" without a semicolon, thus enabling every single option if it finds "false;" instead.

BTW: webpack-dashboard seems to introduce serious memory leak issues. It took me ages to hunt these down, because I thought I had disabled the dashboard.

jurosh commented 6 years ago

Got same performance issues, thanks god for your advice to remove semicolons.. I've created PR (https://github.com/kitze/custom-react-scripts/pull/121) for this, so hope we can hot-fix this critical issue...

m1n0s commented 6 years ago

@geloescht thanks for your attention! 4 node.js processes had been killing my CPU.

amadeogallardo commented 6 years ago

@geloescht I can confirm the same behavior. Disabling Webpack Dashboard fixed the performance overhead issues and improved the hot reloading times considerably.

The tradeoff was actually having to turn the AC heater on, instead of just using my notebook as a heater by frequently triggering a file change. In this case, it was quite literally a "hot reload".