kitze / custom-react-scripts

[DEPRECATED, use customize-cra] Allow custom config for create-react-app without ejecting
https://custom-react-scripts.netlify.com
MIT License
993 stars 97 forks source link

Upgrade to React Scripts 1.1.14 #142

Closed Eric-Arellano closed 6 years ago

Eric-Arellano commented 6 years ago

Hello, these files could not be automatically merged:

--

I wasn't sure how to test this beyond running the e2e tests? The e2e tests failed, but so do Facebook's master branch, so I'm not sure how to test.

screen shot 2018-05-13 at 10 07 52 am

I'm happy to test with a little more direction - I love this fork and really want to be able to use the new React Fragment syntax <>.

riccoski commented 6 years ago

Hello - I was wondering whether this is fixed? I have upgraded to 0.22 however I noticed that I still need to manually update:

in order to get upload working /Users/riccosobers/projects/exchange/node_modules/custom-react-scripts/config/webpack.config.dev.js

Replace line: 199: exclude: [/.(js|jsx|mjs)$/, /.html$/, /.json$/],

This is in order to solve this issue: https://github.com/facebook/create-react-app/pull/3537

Thank you kindly

jayantbh commented 6 years ago

Hi!

This mentioned upgrading react-scripts to 1.1.14, but the current master on the main CRA has react-scripts at 1.1.5. Was this updated mistakenly, or am I missing something?

Eric-Arellano commented 6 years ago

Hi @jayantbh, ah good catch. I think meant to say 1.1.4, which at the time that was the most up to date.