search

kitze / custom-react-scripts

[DEPRECATED, use customize-cra] Allow custom config for create-react-app without ejecting
https://custom-react-scripts.netlify.com
MIT License
993 stars 97 forks source link

Upgrade style-loader to v0.21.0 to enable HMR for css modules #150

Open holtat opened 6 years ago

holtat commented 6 years ago

I've upgraded style-loader to address issue #144 where using CSS modules would not allow for HMR.

Here is the PR that was merged to allow for CSS modules to work with HMR on style-loader for reference: https://github.com/webpack-contrib/style-loader/pull/298

I don't know of any breaking changes this update would cause.

holtat commented 6 years ago

It looks like this package is out of date on the master branch of create-react-app as well, but up to date on the next branch.

I'm not sure what's preferred. Should I try to update this fork with the next branch of create-react-app?