Incorrect default argument for BoxedAnnotation.one_hot_clip_labels(min_label_fraction=1)

kitzeslab / opensoundscape

Open source, scalable software for the analysis of bioacoustic recordings

http://opensoundscape.org

MIT License

136 stars 15 forks source link

Incorrect default argument for BoxedAnnotation.one_hot_clip_labels(min_label_fraction=1) #1011

Open louisfh opened 3 months ago

louisfh commented 3 months ago

https://github.com/kitzeslab/opensoundscape/blob/379952a6f603d9b3f686051b99f1c3c3c8d6971e/opensoundscape/annotations.py#L621

An incorrect default argument was specified for min_label_fraction in the function BoxedAnnotation.one_hot_clip_labels

The docstring states that the default should be None. I think this bug could have caused incorrect behavior in the past. Problem already addressed, but raising this issue for posterity.