search

kiudee / cs-ranking

Context-sensitive ranking and choice in Python with PyTorch
https://cs-ranking.readthedocs.io
Apache License 2.0
66 stars 15 forks source link

FATE Choice ignores parameters of the fit method #126

Closed helegraf closed 4 years ago

helegraf commented 4 years ago

The fit method parameters are:

https://github.com/kiudee/cs-ranking/blob/49e39df3257679acb157b4ca0f47a8bfaa73866a/csrank/choicefunction/fate_choice.py#L134-L150

However the parameters are not passed to the super class:

https://github.com/kiudee/cs-ranking/blob/49e39df3257679acb157b4ca0f47a8bfaa73866a/csrank/choicefunction/fate_choice.py#L199

https://github.com/kiudee/cs-ranking/blob/49e39df3257679acb157b4ca0f47a8bfaa73866a/csrank/choicefunction/fate_choice.py#L208

kiudee commented 4 years ago

Good find, that is indeed bad and would warrant a bug fix release.

timokau commented 4 years ago

Thanks for reporting :)