kiudee / cs-ranking

Context-sensitive ranking and choice in Python with PyTorch
https://cs-ranking.readthedocs.io
Apache License 2.0
66 stars 15 forks source link

Fix baseline choice parameter #134

Closed timokau closed 4 years ago

timokau commented 4 years ago

Description

I believe this fixes #127, though I'm not entirely sure what the intended behaviour of the baseline choice function is. Why does it expect Y on predict? Even if it is a baseline and simply predicts the mean, shouldn't it take Y on fit instead?

Motivation and Context

127

How Has This Been Tested?

Testsuite, pre-commit hooks.

Does this close/impact existing issues?

Fixes #127.

Types of changes

Checklist:

codecov[bot] commented 4 years ago

Codecov Report

Merging #134 into master will decrease coverage by 0.01%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   59.97%   59.96%   -0.02%     
==========================================
  Files         116      116              
  Lines        7656     7658       +2     
==========================================
  Hits         4592     4592              
- Misses       3064     3066       +2     
Impacted Files Coverage Δ
csrank/choicefunction/baseline.py 36.36% <0.00%> (-2.35%) :arrow_down: