Closed timokau closed 4 years ago
Merging #134 into master will decrease coverage by
0.01%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
- Coverage 59.97% 59.96% -0.02%
==========================================
Files 116 116
Lines 7656 7658 +2
==========================================
Hits 4592 4592
- Misses 3064 3066 +2
Impacted Files | Coverage Δ | |
---|---|---|
csrank/choicefunction/baseline.py | 36.36% <0.00%> (-2.35%) |
:arrow_down: |
Description
I believe this fixes #127, though I'm not entirely sure what the intended behaviour of the baseline choice function is. Why does it expect
Y
onpredict
? Even if it is a baseline and simply predicts the mean, shouldn't it takeY
on fit instead?Motivation and Context
127
How Has This Been Tested?
Testsuite, pre-commit hooks.
Does this close/impact existing issues?
Fixes #127.
Types of changes
Checklist: