kiudee / cs-ranking

Context-sensitive ranking and choice in Python with PyTorch
https://cs-ranking.readthedocs.io
Apache License 2.0
66 stars 15 forks source link

Fix optional import, release 1.2.1 #138

Closed timokau closed 4 years ago

timokau commented 4 years ago

Description

Fixing critical bug #137.

Motivation and Context

As @kiudee said so fittingly in #137, "This should definitely not happen".

How Has This Been Tested?

Pre-commit hooks & test suite. We should do #139 at some point.

Does this close/impact existing issues?

Fixes #137

Types of changes

Checklist:

codecov[bot] commented 4 years ago

Codecov Report

Merging #138 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   59.96%   59.96%           
=======================================
  Files         116      116           
  Lines        7658     7658           
=======================================
  Hits         4592     4592           
  Misses       3066     3066           
Impacted Files Coverage Δ
csrank/__init__.py 100.00% <100.00%> (ø)