kiudee / cs-ranking

Context-sensitive ranking and choice in Python with PyTorch
https://cs-ranking.readthedocs.io
Apache License 2.0
66 stars 15 forks source link

clear_memory still needed #148

Closed timokau closed 4 years ago

timokau commented 4 years ago

Most (all?) of our estimators have a clear_memory function that simply resets the estimator while keeping the neural network's weights. The documentation mentions "memory leaks". Are those still an issue? What was the original motivation for adding that function, is there some way to reproduce the issue?

CC @kiudee @prithagupta

kiudee commented 4 years ago

I remember vaguely that this was due to reusing the same session during hyperparameter optimization. The older models would not be removed and accumulate in the memory. @prithagupta do you remember the exact reason?

timokau commented 4 years ago

I propose to remove it in https://github.com/kiudee/cs-ranking/pull/150.