Closed timokau closed 4 years ago
Merging #150 into master will increase coverage by
0.47%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #150 +/- ##
==========================================
+ Coverage 57.77% 58.25% +0.47%
==========================================
Files 113 113
Lines 6960 6848 -112
==========================================
- Hits 4021 3989 -32
+ Misses 2939 2859 -80
Impacted Files | Coverage Δ | |
---|---|---|
csrank/choicefunction/cmpnet_choice.py | 94.59% <ø> (+2.28%) |
:arrow_up: |
csrank/choicefunction/fate_choice.py | 95.12% <ø> (+4.21%) |
:arrow_up: |
csrank/choicefunction/feta_choice.py | 66.20% <ø> (+0.66%) |
:arrow_up: |
csrank/choicefunction/ranknet_choice.py | 94.73% <ø> (+4.49%) |
:arrow_up: |
csrank/core/cmpnet_core.py | 97.72% <ø> (+10.34%) |
:arrow_up: |
csrank/core/fate_network.py | 70.15% <ø> (+3.49%) |
:arrow_up: |
csrank/core/feta_network.py | 64.89% <ø> (+3.43%) |
:arrow_up: |
csrank/core/ranknet_core.py | 97.72% <ø> (+10.34%) |
:arrow_up: |
csrank/discretechoice/cmpnet_discrete_choice.py | 100.00% <ø> (+3.22%) |
:arrow_up: |
csrank/discretechoice/fate_discrete_choice.py | 100.00% <ø> (+5.88%) |
:arrow_up: |
... and 8 more |
Travis has succeeded but that information apparently somehow got lost in transit. Can we restart that check?
Restarting the build somehow did not fix it. I think the only thing we could do is to push something to trigger the whole process again. If that does not work I will investigate if there is some connection issue between Github and Travis CI (so far there is no error message).
Looks like this issue: https://travis-ci.community/t/known-issue-travis-ci-reports-expected-waiting-for-status-to-be-reported-on-the-github-status-api-but-the-status-never-arrives/1154 I deactivated the status check for now until I update travis to the new format.
Yeah I saw that too, very weird that it is just one report (all the previous ones seem outdated) and it isn't acknowledged yet.
Anyway, thanks for the review!
Description
Removing
clear_memory
andhash_file
to reduce complexity and get one step further towards stateless / scikit-learn compatible estimators.Motivation and Context
See description.
How Has This Been Tested?
Tests and pre-commit.
Does this close/impact existing issues?
Fixes #148, step towards #94 / #116.
Types of changes
Checklist: